Repository navigation
[TT-18717] Build the MCP qualification mock from tyk-mock-mcp-server main - #177
konrad-sol wants to merge 1 commit into
Conversation
…main b239c88 includes #12: tool handlers read their own request's headers. The previous pin shared the last request's headers across concurrent calls, so header tests fail at random now that the MCP tests run in parallel (tyk-analytics#6479). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zizmor findings
Full details are in the workflow run. |
|
This pull request updates the version of the The primary motivation for this update is to fix a race condition that was causing flaky tests. The previous version of the mock server was not thread-safe for parallel test execution, as it stored request headers in a global variable. The new version resolves this by ensuring each handler reads headers from its own request, thus stabilizing the tests. Files Changed Analysis
Architecture & Impact Assessment
graph TD
A["mcp-qualification.yml workflow"] --> B{"actions/checkout step"};
B --> C["Dependency: tyk-mock-mcp-server"];
subgraph C
direction LR
D[Old Commit: 29fefa17] --|Update to|--> E[New Commit: b239c88];
end
subgraph "Reason for Change"
F[Old version had race condition in parallel tests] --> G[New version is thread-safe];
end
E --> G;
Scope Discovery & Context ExpansionThe Metadata
Powered by Visor from Probelabs Last updated: 2026-11-10T18:50:25.590Z | Triggered by: pr_opened | Commit: 5d30345 💡 TIP: You can chat with Visor using |
Security Issues (1)
Security Issues (1)
No architecture issues found – changes LGTM. ✅ Performance Check PassedNo performance issues found – changes LGTM. Powered by Visor from Probelabs Last updated: 2026-11-10T18:49:57.388Z | Triggered by: pr_opened | Commit: 5d30345 💡 TIP: You can chat with Visor using |
|
Not needed: the MCP qualification job is being removed (TykTechnologies/gromit#582); MCP tests move into tyk-pro api-tests (TykTechnologies/tyk-analytics#6479). |
Moves the mock checkout in
mcp-qualification.ymlfrom29fefa17tob239c88(tyk-mock-mcp-servermain).b239c88includes tyk-mock-mcp-server#12: tool handlers read their own request's headers. At29fefa17the mock kept the last request's headers in one global, so with the MCP tests now running in parallel (tyk-analytics#6479) header tests fail at random, e.g.test_multiple_tool_headers("Header 'X-Tool-Header-1' not found").29fefa17is an ancestor ofb239c88; the range also brings in #5 (go-sdk v1.7) and CI-only commits.Consumers pin this workflow by SHA, so nothing changes until they bump. #6479 points at this branch's commit to verify; it will move to the merged commit.
🤖 Generated with Claude Code